Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [weak self] where missing from closures #112

Merged
merged 3 commits into from Jan 30, 2019
Merged

Add [weak self] where missing from closures #112

merged 3 commits into from Jan 30, 2019

Conversation

mederic-p
Copy link
Contributor

Issue/Task Number: 111
Closes #111

Overview

This PR adds the missing [weak self] that avoid retaining cycles from closures where missing.

Changes

  • Add missing [weak self]
  • Rename guard let weakSelf = self else { return } to guard let self = self else { return } following swift 4.2 update

@mederic-p mederic-p requested a review from T-Dnzt January 29, 2019 09:18
@ghost ghost added the s2/wip 🚧 This is still being worked on label Jan 29, 2019
@mederic-p mederic-p added s3/review 👀 This issue is in need of a review kind/refactor ⚙️ and removed s2/wip 🚧 This is still being worked on labels Jan 29, 2019
@mederic-p mederic-p merged commit d7e5eee into master Jan 30, 2019
@ghost ghost removed the s3/review 👀 This issue is in need of a review label Jan 30, 2019
@mederic-p mederic-p deleted the 111-weak-self branch January 30, 2019 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@T-Dnzt T-Dnzt T-Dnzt approved these changes

Assignees

@T-Dnzt T-Dnzt

@mederic-p mederic-p

Labels
kind/refactor ⚙️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mederic-p @T-Dnzt