Prevent page scrolling on copy. #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better cross-browser compatibility exchanged window.scrollX by window.pageXOffset as suggested by MDN (https://developer.mozilla.org/de/docs/Web/API/window/scrollX).
|
I'm not a fan of hijacking the page scroll in order to copy things to clipboard. It seems hacky to me, and for something that only happens on IE/Edge. Thanks for the PR, but first I will see if I can find another way before I merge. |
|
Sure. I agree there are better ways to handle this, and opened an Issue to track the case further. However please note that the actual hijacking is done automatically by IE, and it's unlikely that we'll be able to change that. |
|
Hi Ole, Thanks in advance. |
|
I have just released v1.4.2 with a fix for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On larger pages the scrollbar will jump to the hidden node, i.e. the end of the document on node.select() - at least in IE 11. You can try it at https://plnkr.co/JMOnatFAlWrh0R53FuTu.
The fix is pretty straight-forward and working well for me.