Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGA3-690]: Added ShopeePay under Thailand and Singpaore. #404

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

aashishgurung
Copy link
Contributor

1. Objective

Add ShopeePay for direct integration for Thailand and Singapore. If the website is opened from mobile device then ShopeePay should use Jump App i.e open ShopeePay app.

Jira Ticket: #690

2. Description of change

Added a function isMobilePlatform to check if the current platform is a mobile or not. We added THB and SGD under the supported currency for ShopeePay.

3. Quality assurance

You should enabled ShopeePay direct and ShopeePay Jump App for your account from Opn Payment admin dashboard.

Source type: Shopeepay

  • Place an order selecting ShopeePay
  • You should see QR code in a separate page

Screen Shot 2565-12-14 at 16 07 40

Source type: Shopeepay Jump App

  • Place an order selecting ShopeePay
  • You should see a different page if you are in laptop that shows QR code and the process to scan using phone.

Screen Shot 2565-12-14 at 16 08 54

🔧 Environments:

  • Platform version: Magento 2.4.5
  • Omise plugin version: Omise-Magento 2.30.0
  • PHP version: 8.1

@aashishgurung aashishgurung changed the title Feature/enga3 690 [ENGA3-690]: Added ShopeePay under Thailand and Singpaore. Dec 14, 2022
…choose right backend and source for shopee.
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants