-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENGA3-690]: Added ShopeePay under Thailand and Singpaore. #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… App if the platform is mobile device.
ajzkk
approved these changes
Dec 14, 2022
kan98
approved these changes
Dec 14, 2022
new4762
reviewed
Dec 14, 2022
tookaa2
approved these changes
Dec 15, 2022
new4762
reviewed
Dec 15, 2022
new4762
reviewed
Dec 15, 2022
…choose right backend and source for shopee.
new4762
approved these changes
Dec 15, 2022
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Add ShopeePay for direct integration for Thailand and Singapore. If the website is opened from mobile device then ShopeePay should use
Jump App
i.e open ShopeePay app.Jira Ticket: #690
2. Description of change
Added a function
isMobilePlatform
to check if the current platform is a mobile or not. We addedTHB
andSGD
under the supported currency for ShopeePay.3. Quality assurance
You should enabled ShopeePay direct and ShopeePay Jump App for your account from Opn Payment admin dashboard.
Source type:
Shopeepay
Source type:
Shopeepay Jump App
🔧 Environments: