[ENGA3-689]: Added ShopeePay direct and jumpapp for Thailand and Sing… #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
new4762
approved these changes
Jan 6, 2023
ajzkk
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Added ShopeePay direct and jumpapp for Thailand and Singapore
Jira Ticket: #689
2. Description of change
Added
THandSGas currencies for Shopee Pay. Added a logic to add the Shopee Pay's source type as per the available capabilities and device. Did some minor refactoring inincludes/class-omise-capabilities.phpAdditionally add the reasoning for change details if they're complex or abstract.
3. Quality assurance
Follow the steps mentioned in the following PR's Quality assurance section.
Magento PR: #404
🔧 Environments: