Revert "Use wc order number metadata (#435)"

This reverts commit a5354f3.

includes/gateway/abstract-omise-payment-base-card.php

@@ -62,14 +62,13 @@ private function getOmiseCustomerId($user) {
 	private function prepareChargeData($order_id, $order, $omise_customer_id, $card_id, $token)
 	{
 		$currency = $order->get_currency();
-		$order_number = $order->get_order_number();
 		$data = [
 			'amount' => Omise_Money::to_subunit($order->get_total(), $currency),
 			'currency' => $currency,
-			'description' => 'WooCommerce Order id ' . $order_number,
+			'description' => 'WooCommerce Order id ' . $order_id,
 			'return_uri' => $this->get_redirect_url('omise_callback', $order_id, $order),
 			'metadata' => $this->get_metadata(
-				$order_number,
+				$order_id,
 				[ 'secure_form_enabled' => $this->getSecureFormState()]
 			),
 		];

includes/gateway/traits/charge-request-builder-trait.php

@@ -10,14 +10,13 @@ public function build_charge_request(
 	)
 	{
 		$currency = $order->get_currency();
-		$order_number = $order->get_order_number();
-		$description = 'WooCommerce Order id ' . $order_number;
+		$description = 'WooCommerce Order id ' . $order_id;
 
 		$request = [
 			'amount'      => Omise_Money::to_subunit($order->get_total(), $currency),
 			'currency'    => $currency,
 			'description' => $description,
-			'metadata'    => $this->get_metadata($order_number),
+			'metadata'    => $this->get_metadata($order_id),
 			'source' 	  => [ 'type' => $source_type ]
 		];
 
@@ -41,13 +40,13 @@ public function build_charge_request(
 	}
 
 	/**
-	 * @param string $order_number
+	 * @param string $order_id
 	 * @param array $additionalData
 	 */
-	public function get_metadata($order_number, $additionalData = [])
+	public function get_metadata($order_id, $additionalData = [])
 	{
 		// override order_id as a reference for webhook handlers.
-		$orderId = [ 'order_id' => $order_number ];
+		$orderId = [ 'order_id' => $order_id ];
 		return array_merge($orderId, $additionalData);
 	}
 

tests/unit/includes/gateway/abstract-omise-payment-base-card-test.php

@@ -62,8 +62,6 @@ public function getOrderMock($expectedAmount, $expectedCurrency)
             ->andReturn($expectedAmount);  // in units
         $orderMock->shouldReceive('add_meta_data')
             ->andReturn(['order_id' => 'order_123']);
-        $orderMock->shouldReceive('get_order_number')
-            ->andReturn(1234);
         $orderMock->shouldReceive('get_user')
             ->andReturn((object)[
                 'ID' => 'user_123',

tests/unit/includes/gateway/traits/charge-request-builder-test.php

@@ -34,8 +34,6 @@ public function getOrderMock($expectedAmount, $expectedCurrency)
         $orderMock->shouldReceive('get_total')
             ->andReturn($expectedAmount);  // in units
         $orderMock->shouldReceive('add_meta_data');
-        $orderMock->shouldReceive('get_order_number')
-            ->andReturn(1234);
         return $orderMock;
     }