Use wc order number metadata #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aashishgurung
requested review from
vault087,
AnasNaouchi,
annatotest and
a team
AnasNaouchi
approved these changes
Mar 4, 2024
annatotest
approved these changes
Mar 4, 2024
Merged
aashishgurung
added a commit
that referenced
this pull request
Mar 7, 2024
This reverts commit a5354f3.
aashishgurung
added a commit
that referenced
this pull request
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
get_order_numberinstead oforder_idfor the charge metadata so that users can customize order number.Decision(s)
It is safe to replace order ID with
get_order_numberfor the use case because it returns order ID by default. If user choose to customize order number using some plugins then it will return the order number in the new format.https://woocommerce.github.io/code-reference/classes/WC-Order.html#method_get_order_number
Rollback procedure
default rollback procedure