Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGA3-1334]: Remove free products from the Atome bill #378

Merged
merged 3 commits into from May 23, 2023

Conversation

aashishgurung
Copy link
Contributor

1. Objective

Remove free or complimentary products from the Atome bill

Jira Ticket: #1334

2. Description of change

Add a logic to check the price of subtotal which is the total amount of the products combined excluding shipping cost.

Screenshot 2566-05-19 at 12 30 26

3. Quality assurance

  • Add a freebie product in the cart
  • Try to pay via Atome

🔧 Environments:

  • WooCommerce: v6.7.0
  • WordPress: v6.0.2
  • PHP version: 8.1
  • Omise WooCommerce: 5.1.0

@aashishgurung aashishgurung merged commit 1488f57 into develop May 23, 2023
3 checks passed
@aashishgurung aashishgurung mentioned this pull request Jun 12, 2023
aashishgurung added a commit that referenced this pull request Jun 13, 2023
* [ENGA3-1334]: Fix invalid product issue with variance item (#377)

* [ENGA3-1334]: Added WC_Product_Variation class when the item is a variant to fix the invalid prodcut issue. Atome logo is also added.

* Fixed formatting.

---------

Co-authored-by: Aashish <aashish@omise.co>

* [ENGA3-1334]: Remove free products from the Atome bill (#378)

* [ENGA3-1334]: Remove free products from Atome product list.

* [ENGA3-1134]: Updated the message for Atome on freebie products.

* [ENGA3-1134]: Check subtotal instead of price per item when comparing to zero.

---------

Co-authored-by: Aashish <aashish@omise.co>

* fixed not compatible with country based payments plugin (#379)

* Preparing release of v5.1.1

* Updated release date

---------

Co-authored-by: Aashish <aashish@omise.co>
Co-authored-by: (AJ) Zin Kyaw Kyaw <108650842+ajzkk@users.noreply.github.com>
@aashishgurung aashishgurung deleted the bug/ENGA3-1134-remove-free-products-atome branch August 18, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants