Bug Fixed not compatible with country based payments plugin #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajzkk
changed the title
danfowler
reviewed
Jun 1, 2023
|
Can you add more description about how other plugins removed code from our plugin? How does this change prevents that? |
I do not know how their plugin work, but I can visually see in checkout page that card payment is missing, and also if you try to inspect, you will see card payment element is missing until user select the country. So I check with the element. If element is missing, then do not run |
danfowler
approved these changes
Jun 2, 2023
aashishgurung
approved these changes
Jun 2, 2023
Merged
aashishgurung
added a commit
that referenced
this pull request
Jun 13, 2023
* [ENGA3-1334]: Fix invalid product issue with variance item (#377) * [ENGA3-1334]: Added WC_Product_Variation class when the item is a variant to fix the invalid prodcut issue. Atome logo is also added. * Fixed formatting. --------- Co-authored-by: Aashish <aashish@omise.co> * [ENGA3-1334]: Remove free products from the Atome bill (#378) * [ENGA3-1334]: Remove free products from Atome product list. * [ENGA3-1134]: Updated the message for Atome on freebie products. * [ENGA3-1134]: Check subtotal instead of price per item when comparing to zero. --------- Co-authored-by: Aashish <aashish@omise.co> * fixed not compatible with country based payments plugin (#379) * Preparing release of v5.1.1 * Updated release date --------- Co-authored-by: Aashish <aashish@omise.co> Co-authored-by: (AJ) Zin Kyaw Kyaw <108650842+ajzkk@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Bug Fixed not compatible with country based payments plugin
2. Description of change
Country based payments plugin remove the the whole html element of omise card payment, if user not selected the country in shipping address.
3. Quality assurance
Tested locally with
4. Impact of the change
N/A
5. Priority of change
Normal