Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Refactoring and fix Ui issue #376

Merged
merged 61 commits into from
Jul 26, 2018
Merged

Refactoring and fix Ui issue #376

merged 61 commits into from
Jul 26, 2018

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Jul 24, 2018

Issue/Task Number: #370

Overview

This PR fix Design issue and refactor parts of the big files component.

Changes

  • Fix Total supply shows 0 after minting a token on creation
  • Fix When accessing a wallet detail, the "Wallet" section is not highlighted anymore in the menu
  • Show primary/burn/secondary in wallets list when making a transaction
  • Fix can't see all the wallets when creating a transaction request
  • Fix input floating placeholder browser compatibility
  • Rename public/private to access/secret in Key listing
  • Add copy icon for ID in every table and screen
  • Always show the copy icon on detail page
  • Allow amount to not be passed when creating a token
  • Add tooltip in transaction modal to explain the second token / amount fields
  • Add client validation for max 18 digits when creating a token
  • View token history is not working (wrong link with 2 /)
  • Add copy button for API keys
  • Refactor big files

Usage

  • for the new dropdown wallet, go to any page that has the select wallet input and try searching

Impact

Deploy as usual.

screen shot 2018-07-25 at 12 44 04 am

@ghost ghost assigned jarindr Jul 24, 2018
@ghost ghost added the s2/wip 🚧 label Jul 24, 2018
@jarindr jarindr requested review from T-Dnzt and unnawut July 25, 2018 03:45
@mederic-p
Copy link
Contributor

mederic-p commented Jul 26, 2018

  • Can’t edit account categories
  • Can’t click on the breadcrumb to navigate
  • In the Key lists (in the tables) rename the header Key to API Key for eWallet API Keys and rename Key to Access Key for the Access keys
  • In the Key lists: Rename the Generate Key button to Generate API Key and Generate Access Key
  • Genesis address GET error is not handled
  • Missing copy to clipboard buttons in history
  • Transaction request/consumption still not support exchange
  • Clear address input on transaction consumption
  • Status column in consumption list should use the same graphics as the status column in transaction list
  • Can we make the Account ID clickable (same as the Account Name) in the transaction request Tab?
  • Can we make the User ID clickable in the transaction request tab?
  • Also in the consumption tab, addresses and Ids should be clickable
  • Client validation 18 decimals

@jarindr jarindr merged commit 58e24b0 into master Jul 26, 2018
@ghost ghost removed the s3/review label Jul 26, 2018
@jarindr jarindr deleted the refactoring branch July 26, 2018 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug ⚠️ Something isn't working kind/enhancement 🚀 New feature or request kind/refactor ⚙️ This is only about refactoring, no new feature. p2/normal This is something that should be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants