Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

strict dialyzer analysis #424

Merged
merged 3 commits into from
Aug 17, 2018
Merged

strict dialyzer analysis #424

merged 3 commits into from
Aug 17, 2018

Conversation

InoMurko
Copy link

Issue/Task Number:

Overview

Added a more strict Dialyzer setting.

Changes

Fixed the reported issues from master.

Implementation Details

Fixed specs

Usage

/

Impact

Nothing mayor.

Copy link
Contributor

@unnawut unnawut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised by how little changes needed for those extra flags. Thanks!

@unnawut unnawut requested a review from T-Dnzt August 17, 2018 10:57
@unnawut unnawut added kind/enhancement 🚀 New feature or request p2/normal This is something that should be done labels Aug 17, 2018
@unnawut unnawut added this to the v1.0 milestone Aug 17, 2018
@unnawut
Copy link
Contributor

unnawut commented Aug 17, 2018

This should be able to go with v1.0 since it's only @spec changes

@ghost ghost assigned unnawut Aug 17, 2018
@ghost ghost added the s2/wip 🚧 label Aug 17, 2018
@InoMurko
Copy link
Author

InoMurko commented Aug 17, 2018

if you added :specdiffs to the configuration things would look different :-) I suggest you try it out and decide whether you think it's useful.

On the other hand I didn't include overspecs, I don't think it's useful much.

@unnawut unnawut merged commit a0a6a76 into omgnetwork:master Aug 17, 2018
@ghost ghost removed the s2/wip 🚧 label Aug 17, 2018
@unnawut
Copy link
Contributor

unnawut commented Aug 17, 2018

Thank you for your PR! 🎖🥇🥈🍾 🌟

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement 🚀 New feature or request p2/normal This is something that should be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants