Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Improve search for wallets, tokens, users and fix bug error login message #512

Merged
merged 27 commits into from
Nov 19, 2018

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Nov 8, 2018

Issue/Task Number: #509 #500

Overview

This PR prepare module for searching from various keyword in modules like wallets, users, tokens for better searching functionality.

Changes

  • Add search fields for modules.
  • Fix error handling login.
  • search wallet by accountId, address
  • search user by userId, email, username
  • search token by id, symbol

Usage

Login with wrong password, now it should be handled correctly.
try searching wallets,users,tokens

Impact

Deploy as usual.

@ghost ghost assigned jarindr Nov 8, 2018
@ghost ghost added the s2/wip 🚧 label Nov 8, 2018
@jarindr jarindr added kind/bug ⚠️ Something isn't working kind/enhancement 🚀 New feature or request p0/highest This is something that should be done now and removed s2/wip 🚧 labels Nov 14, 2018
@jarindr jarindr changed the title Prepare for advance search and fix bug error login message Improve search for wallets, tokens, users and fix bug error login message Nov 14, 2018
@ghost ghost added the s2/wip 🚧 label Nov 15, 2018
T-Dnzt
T-Dnzt previously requested changes Nov 16, 2018
Copy link

@T-Dnzt T-Dnzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add token name for token search? Also, please double-check that all shown column names are being searched for in the requests.

@jarindr jarindr merged commit e079c9d into master Nov 19, 2018
@ghost ghost removed the s2/wip 🚧 label Nov 19, 2018
@jarindr jarindr deleted the 500-search-walelt branch November 19, 2018 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug ⚠️ Something isn't working kind/enhancement 🚀 New feature or request p0/highest This is something that should be done now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants