Skip to content
This repository has been archived by the owner on Jun 30, 2021. It is now read-only.

Configuration system for admin panel #575

Merged
merged 130 commits into from
Dec 19, 2018
Merged

Configuration system for admin panel #575

merged 130 commits into from
Dec 19, 2018

Conversation

jarindr
Copy link
Contributor

@jarindr jarindr commented Dec 4, 2018

Issue/Task Number: #557

Overview

This PR add configuration system page to admin panel.

Changes

  • Add configuration system to admin panel.
  • rename endpoint from .get to .all for consistency.
  • rename module ConfigurationSerializer.
  • refactor redux store loading state.
  • change how configuration endpoint works, from paginated to returning all data.
  • remove deprecated function like Ecto.date and fix test case.

Implementation Details

  • the old redux store loading state for each node was separated before for flat tree, but we realize it makes tree too ugly and hard to maintain so we changed back to a single state tree for all loading state.

Usage

Go to configuration page and test around.

Impact

  • Deploy as usual, anyone testing this branch please clean your compiled code and db first to avoid bugs.

screen shot 2018-12-11 at 5 03 35 pm

apps/ewallet_db/mix.exs Outdated Show resolved Hide resolved
@jarindr jarindr merged commit ca7d18e into master Dec 19, 2018
@ghost ghost removed the s3/review 👀 label Dec 19, 2018
@jarindr jarindr deleted the 557-configuration-page branch December 19, 2018 08:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants