Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to swift 5 #124

Merged
merged 7 commits into from
Apr 26, 2019
Merged

Update to swift 5 #124

merged 7 commits into from
Apr 26, 2019

Conversation

mederic-p
Copy link
Contributor

Issue/Task Number: 122
Closes #122

Overview

This PR updates the code to the new swift 5 syntax.

Changes

  • Update the Response<Data> enum to use the new swift 5 Result<Data, OMGError> instead
  • Update swiftformat version
  • Update copyright year

Impact

Projects that integrate the SDK will need to update the syntax of the Response callback on API calls to follow the new swift 5 syntax.

@mederic-p mederic-p self-assigned this Apr 5, 2019
@mederic-p mederic-p requested review from T-Dnzt and ripzery April 5, 2019 08:47
@ghost ghost added the s2/wip 🚧 This is still being worked on label Apr 5, 2019
@mederic-p mederic-p merged commit bc458e8 into 1.2 Apr 26, 2019
@mederic-p mederic-p removed the s2/wip 🚧 This is still being worked on label Apr 26, 2019
@mederic-p mederic-p deleted the 122-swift5 branch April 26, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants