Kevin/allow zero value outputs #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
souradeep-das
approved these changes
Mar 17, 2021
…misego/plasma-contracts into kevin/allow-zero-value-outputs
InoMurko
suggested changes
Mar 18, 2021
| @@ -42,7 +42,7 @@ bool private bootDone; | |||
| ```js | |||
| event IFEBondUpdated(uint128 bondSize); | |||
| event PiggybackBondUpdated(uint128 bondSize, uint128 exitBountySize); | |||
| event InFlightExitStarted(address indexed initiator, bytes32 indexed txHash, bytes inFlightTx, uint256[] inputUtxosPos, bytes[] inFlightTxWitnesses bytes[] inputTxs); | |||
| event InFlightExitStarted(address indexed initiator, bytes32 indexed txHash); | |||
There was a problem hiding this comment.
why did this happen? didn't we actually add
bytes inFlightTx, uint256[] inputUtxosPos, bytes[] inFlightTxWitnesses bytes[] inputTxs
There was a problem hiding this comment.
Just the generated docs coming up to date. The InFlightExitStarted event in PaymentStartInFlightExit.sol is correct
InoMurko
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.