-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kevin/allow zero value outputs #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍
we could also re-generate the docs
…misego/plasma-contracts into kevin/allow-zero-value-outputs
@@ -42,7 +42,7 @@ bool private bootDone; | |||
```js | |||
event IFEBondUpdated(uint128 bondSize); | |||
event PiggybackBondUpdated(uint128 bondSize, uint128 exitBountySize); | |||
event InFlightExitStarted(address indexed initiator, bytes32 indexed txHash, bytes inFlightTx, uint256[] inputUtxosPos, bytes[] inFlightTxWitnesses bytes[] inputTxs); | |||
event InFlightExitStarted(address indexed initiator, bytes32 indexed txHash); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did this happen? didn't we actually add
bytes inFlightTx, uint256[] inputUtxosPos, bytes[] inFlightTxWitnesses bytes[] inputTxs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the generated docs coming up to date. The InFlightExitStarted
event in PaymentStartInFlightExit.sol
is correct
No description provided.