R SDK For ADLS: Rename all APIs similar to rhdfs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export(adls.fileinputstream.close) | ||
| export(adls.fileinputstream.getpos) | ||
| export(adls.fileinputstream.length) | ||
| export(adls.fileinputstream.mark) |
There was a problem hiding this comment.
AFAIK these are just there from Java InputStream definition, so the mark methods can be removed from R.
There was a problem hiding this comment.
trying to make it similar to the ADLS Java SDK. Here too the execution stops with a message like "UnsupportedOperationException: mark()/reset() not supported on this stream ..."
| export(adlFileOutputStreamFlush) | ||
| export(adlFileOutputStreamWrite) | ||
| export(adls.append) | ||
| export(adls.append.direct) |
There was a problem hiding this comment.
What does append.direct do as opposed to just append? (same for read and read.direct)
There was a problem hiding this comment.
The .direct methods complete the operation in one step, without providing the user with a file IO streams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rhdfs: https://github.com/RevolutionAnalytics/RHadoop/wiki/user%3Erhdfs%3EHome