-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AMDGPU v0.5 support #107
Conversation
luraess
commented
Jul 21, 2023
•
edited
edited
- transition AMDGPU to HIP backend
- requires CellArray compat bump Bump AMDGPU version CellArrays.jl#20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@@ -162,6 +162,7 @@ end | |||
return | |||
end | |||
@parallel write_indices!(A); | |||
if $package == $PKG_AMDGPU AMDGPU.HIP.device_synchronize() end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HOTFIX: device sync is somehow needed here and in later tests (mostly 3D). One should still investigate why further @omlins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This relates to #106 description added in the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will merge it as we need to release today. We can still check this...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay