Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix stream sync for AMDGPU backend #109

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Fix stream sync for AMDGPU backend #109

merged 1 commit into from
Aug 23, 2023

Conversation

luraess
Copy link
Collaborator

@luraess luraess commented Aug 2, 2023

Fixes #108

@luraess luraess requested a review from omlins August 2, 2023 16:42
@luraess
Copy link
Collaborator Author

luraess commented Aug 2, 2023

Now all tests pass again without having to use AMDGPU.HIP.device_synchronize().

@luraess
Copy link
Collaborator Author

luraess commented Aug 22, 2023

@omlins

omlins
omlins approved these changes Aug 23, 2023
View reviewed changes
Copy link
Owner

@omlins omlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@omlins omlins merged commit 7a69c79 into main Aug 23, 2023
6 checks passed
@omlins omlins deleted the lr/sync-fix branch August 23, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omlins omlins omlins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sync issues on AMDGPU backend
2 participants
@luraess @omlins