Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong colors in IDE on macOS dark mode #1103

Closed
rhornig opened this issue Feb 16, 2024 · 1 comment
Closed

Wrong colors in IDE on macOS dark mode #1103

rhornig opened this issue Feb 16, 2024 · 1 comment
Assignees
@rhornig
Labels
in IDE / result analysis minor Inconvenience that can be worked around
Milestone
6.1

Comments

@rhornig
Copy link
Contributor

rhornig commented Feb 16, 2024

Platform

  • OMNeT++ version: 6.0.3
  • OS: macOS 14

Describe the bug
Running in dark mode shows some incorrect text color settings.

To Reproduce
see attached screenshots.
image
image
@rhornig rhornig added the new New issue that has not been yet acknowledged label Feb 16, 2024
@rhornig rhornig added this to the 6.1 milestone Feb 16, 2024
@rhornig rhornig self-assigned this Feb 16, 2024
@rhornig rhornig added minor Inconvenience that can be worked around in IDE / result analysis and removed new New issue that has not been yet acknowledged labels Feb 16, 2024
@rhornig
Copy link
Contributor Author

rhornig commented Sep 10, 2024

Caused by the NSRequiresAquaSystemAppearance in the Info.plist file of the IDE. This
flag is automatically added to the Tycho build process to explicitly disable dark mode
support for the IDE. It seems that Eclipse now properly supports dark mode on macOS so
we no longer need this flag.

The fix should remove the flag from the Info.plust file during the build process.

@rhornig rhornig closed this as completed Sep 10, 2024
torokati44 pushed a commit to torokati44/omnetpp that referenced this issue Sep 18, 2024
@rhornig
ide: fix omnetpp#1103 where IDE was not properly supporting dark mode…
5151e65 
… on macOS

background/foreground colors on some tree and table view was incorrect
in the result analysis and sequence chart views in dark mode.

This happened because the IDE build process incorrectly added NSRequiresAquaSystemAppearance
to the Info.plist file disabling dark mode support for the IDE process.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhornig rhornig

Labels
in IDE / result analysis minor Inconvenience that can be worked around
Projects
None yet
Milestone
6.1
Development

No branches or pull requests
1 participant
@rhornig