Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --print_config skip_default #91

Closed
carmocca opened this issue Sep 16, 2021 · 1 comment · Fixed by #132
Closed

Support --print_config skip_default #91

carmocca opened this issue Sep 16, 2021 · 1 comment · Fixed by #132
Labels
enhancement New feature or request

Comments

@carmocca
Copy link
Contributor

Add support for --print_config skip_default so only the values different to the default are printed.

Two main benefits:

  • Removes the manual work of removing the extra arguments from a config. However, this isn't recommended for reproducibility as it's useful to know exactly what was set.
  • Improves backward compatibility. Often features are deprecated in a way that the default argument for a function is re-routed to the new implementation. Since the config saves all old defaults and passes them to the program, it is likely the program will fail when support for the old value is removed.
@mauvilsa mauvilsa added the enhancement New feature or request label Sep 16, 2021
@carmocca carmocca mentioned this issue Jan 4, 2022
Closed
mauvilsa added a commit that referenced this issue Mar 15, 2022
@mauvilsa
Added dump option to exclude entries whose value is the same as the d…
81d7b8b 
…efault #91.
@mauvilsa mauvilsa mentioned this issue Mar 15, 2022
Merged
@mauvilsa
Copy link
Member

An initial version of this is implemented in pull request #132. @carmocca can you please test this hopefully with some real use case.

mauvilsa added a commit that referenced this issue Mar 29, 2022
@mauvilsa
Added dump option to exclude entries whose value is the same as the d…
3107aed 
…efault #91.
mauvilsa added a commit that referenced this issue Mar 31, 2022
@mauvilsa
Added dump option to exclude entries whose value is the same as the d…
53c168a 
…efault #91.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New dump option to exclude entries whose value is the same as the default omni-us/jsonargparse
2 participants
@mauvilsa @carmocca