Skip to content

Commit

Permalink
Bump version to 1.2.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@sferik
sferik committed Jan 16, 2014
1 parent 6da9a13 commit 7e5ae2a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/omniauth/version.rb
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module OmniAuth
VERSION = '1.1.4' unless defined?(OmniAuth::VERSION)
VERSION = '1.2.0'
end

5 comments on commit 7e5ae2a

@clemens
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What has changed since 1.1.x? Is there something like a changelog? omniauth-oauth 1.1.2 (= patch release) seems to require this version (= minor release) which kind of confuses me.

@sferik
Copy link
Contributor Author

@sferik sferik commented on 7e5ae2a Jan 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t maintain a summarized changelog but here is the complete git history/diff between those two versions: v1.1.4...v1.2.0.

omniauth-oauth 1.1.2 (= patch release) seems to require this version (= minor release) which kind of confuses me.

What would be the reason for omniauth-oauth2 not to depend on the latest version of omniauth (and oauth2)? If another gem in your Gemfile depends on omniauth ~> 1.1.0, that dependency should probably be relaxed to ~> 1.1 to allow 1.2 and future 1.x releases.

@clemens
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just so I understand this correctly: The patch release for omniauth-oauth2 means that its API should be fully backwards compatible to the previous patch release but for omniauth it could differ (since the minor version changed). Right? Or are you not following SemVer?

@sferik
Copy link
Contributor Author

@sferik sferik commented on 7e5ae2a Jan 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Both releases should be fully backwards compatible. Major version number changes indicate backward incompatible changes, according to Semantic Versioning, which we aim to follow.

@twelvelabs
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either a Changelog file or notes in Github's 'releases' tab would be incredibly helpful for those of us maintaining multiple apps. I can't always tell when a gem follows Semantic Versioning (and regardless, I've been burned before by those that do). It's very time consuming to have to manually diff release tags.

Please sign in to comment.