Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strategy#mock_request_call bug #576

Merged
merged 1 commit into from
Feb 14, 2012
Merged

Strategy#mock_request_call bug #576

merged 1 commit into from
Feb 14, 2012

Conversation

SkyWriter
Copy link
Contributor

This code illustrates the issue:

class TestCase

  attr_reader :response

  def initialize
    @response = "What will be returned"
  end

  def call_through_to_app
    "What is supposed to be returned"
  end

  def mock_request_call
    return response if response = call_through_to_app
  end
end

test = TestCase.new
puts test.mock_request_call

This code in Strategy does not seem to do what it was supposed to be doing. Fixing this made my OmniAuth Facebook/Twitter tests green again.

@SkyWriter
Copy link
Contributor Author

Forgot the output:

  1.9.3-p0 :057 > puts test.mock_request_call
  What will be returned
   => nil 

mbleigh pushed a commit that referenced this pull request Feb 14, 2012
Strategy#mock_request_call bug
@mbleigh mbleigh merged commit 7cc0a8b into omniauth:master Feb 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants