Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare distinct states with _latestUnfiltered rather than present #173

Closed
davidroeca opened this issue Jul 7, 2017 · 2 comments
Closed

Compare distinct states with _latestUnfiltered rather than present #173

davidroeca opened this issue Jul 7, 2017 · 2 comments

Comments

@davidroeca
Copy link
Collaborator

Mentioned in #171 by @xargi

The thought is that filtered state might invalidate unfiltered actions that yield the same current state, which prevents it from being recorded in the history.

The fix: change history.present === res to history._latestUnfiltered === res
@davidroeca davidroeca mentioned this issue Jul 7, 2017
Closed
davidroeca added a commit to davidroeca/redux-undo that referenced this issue Jul 7, 2017
@davidroeca
handle omnidan#173
e6be11c
@davidroeca davidroeca mentioned this issue Jul 10, 2017
Merged
@omnidan
Copy link
Owner

omnidan commented Jul 14, 2017

published 9-9-6 with this fix, let me know if it works!

@welkup
Copy link

welkup commented Jul 20, 2017

Works as expected. Thanks so much!

@nmay231 nmay231 mentioned this issue Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@omnidan @davidroeca @welkup