-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HGNC Symbols #7
Comments
I would say that the issue is rekevant for first gen methods, not really for second generation ones
I don't know if there is a standard for gene names for spatial data but I guess it depends on the way the data are processed. To use first generation methods we have to obtain HGNC/MGI symbols. The |
One easy solution could be to use the good old annotables package. I used it years ago but perhaps it could come in hand. I was planning to contribute by adding the latest mouse genome version but haven't heard back from the author yet. |
I think i confused the human / mouse methods here but the questions stays the same. (also didn't knew about the lowercase mouse gene names) Good comments! I think i will implement something to check for the types of gene symbols provided and output something to the user. (this is a human method and you probably provided mouse data + the other way round) Edit: i will leave this open until implemented |
Immunedeconv requires HGNC symbols. The spatial datasets i worked with typically contained ENSEMBL / some form of gene symbol but not all HGNC.
Is this something we should require the user to manage or would it be benefical to implement something to convert the gene names? Often a simpel toupper() is kind of fixing the issue.
Trying to cut down on dependencies here :)
The toupper() solution fixes the HGNCs that are present in lowercase. All other genes are "filtered" by the intersect step between signature and sample as performed in omnideconv. This could remove genes which are otherwise "usable".
The text was updated successfully, but these errors were encountered: