Merge pull request #236 from vanduynslagerp/param-required-validation

Fail validation if @param required attribute is not satisfied
omnifaces · Apr 11, 2016 · 1b6a22f · 1b6a22f
2 parents cd97323 + 02b6f36
commit 1b6a22f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/org/omnifaces/cdi/param/RequestParameterProducer.java b/src/main/java/org/omnifaces/cdi/param/RequestParameterProducer.java
@@ -124,6 +124,7 @@ private Object getConvertedValue(FacesContext context, UIComponent component, St
 
 			if (requestParameter.required() && isEmpty(convertedValue)) {
 				addRequiredMessage(context, component, label, submittedValue, getRequiredMessage(requestParameter));
+				valid = false;
 			}
 
 			// Validate the converted value
@@ -132,8 +133,9 @@ private Object getConvertedValue(FacesContext context, UIComponent component, St
 			if (shouldDoBeanValidation(requestParameter)) {
 
 				Set<ConstraintViolation<?>> violations = doBeanValidation(convertedValue, injectionPoint);
-
-				valid = violations.isEmpty();
+				if (!violations.isEmpty()) {
+					valid = false;
+				}
 
 				for (ConstraintViolation<?> violation : violations) {
 					context.addMessage(component.getClientId(context), createError(violation.getMessage(), label));