Universal support for overriding minimum ashift #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oetiker
previously approved these changes
Sep 5, 2018
|
Fixing #72 |
hadfl
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current system only works for devices that are behind the
sddriver which excludes virtio/blkdev and NVMe. ZFS recently acquired support for overriding the minimum ashift via a global system variable so this change addsmdband supporting files to the miniroot, and then uses it to set the ashift before creating the pool.In addition, the previous boolean 'Force 4K sectors?' option is now a selection menu cycling to allow a choice of 4K or 8K, since some SSDs now use an 8K sector size.