Adding a disconnectAsync method

src/mapd-con-es6.js

@@ -146,7 +146,11 @@ class MapdCon {
           headers: { Connection: "close" },
           https: protocol === "https:"
         })
-        connection.on("error", console.error) // eslint-disable-line no-console
+        connection.on("error", (err) => {
+          throw new Error(
+            `Thrift connection error - ${err.message}\n${JSON.stringify(err, null, 2)}`
+          )
+        })
         client = thriftWrapper.createClient(MapDThrift, connection)
         resetThriftClientOnArgumentErrorForMethods(this, client, [
           "connect",
@@ -323,6 +327,17 @@ class MapdCon {
     return this
   }
 
+  disconnectAsync = () =>
+    new Promise((resolve, reject) => {
+      this.disconnect((error, con) => {
+        if (error) {
+          reject(error)
+        } else {
+          resolve(con)
+        }
+      })
+    })
+
   removeConnection(conId) {
     if (conId < 0 || conId >= this.numConnections) {
       const err = {
@@ -1564,7 +1579,7 @@ class MapdCon {
     const curNonce = (this._nonce++).toString()
 
     if (!callback) {
-      return this.processPixelResults(
+      return this.processHitTestResults(
         undefined, // eslint-disable-line no-undefined
         this._client[this._lastRenderCon].get_result_row_for_pixel(
           this._sessionId[this._lastRenderCon],
@@ -1586,7 +1601,7 @@ class MapdCon {
       columnFormat,
       pixelRadius,
       curNonce,
-      this.processPixelResults.bind(this, callback)
+      this.processHitTestResults.bind(this, callback)
     )
 
     return curNonce
@@ -1655,6 +1670,69 @@ class MapdCon {
     }
   }
 
+  /**
+   * Formats results from getResultRowForPixel calls.
+   *
+   * @param {Function} callback A callback function with the signature `(err, result) => result`.
+   * @param {Object} error An error if thrown; otherwise null.
+   * @param {Array|Object} results Unformatted results of getResultRowForPixel call.
+   *
+   * @returns {Object} An object with formatted hit-test results.
+   */
+  processHitTestResults(callback, error, results) {
+    if (error) {
+      if (callback) {
+        return callback(error, results)
+      } else {
+        throw new Error(
+          `Unable to process getResultRowForPixel() results: ${error}`
+        )
+      }
+    }
+
+    const processResultsOptions = {
+      isImage: false,
+      eliminateNullRows: false,
+      query: "getResultRowForPixel request",
+      queryId: -2
+    }
+    results.row_set = this.processResults(processResultsOptions, results)
+
+    if (typeof results.pixel.x.valueOf === "function") {
+      // TPixels x/y values are I64, which gets converted to a special thrift Int64 representation,
+      // so need to convert to real javascript numbers via the 'valueOf' member function.
+      results.pixel.x = results.pixel.x.valueOf()
+      results.pixel.y = results.pixel.y.valueOf()
+    }
+
+    // eslint-disable-next-line no-console
+    console.assert(results.table_id.length === results.row_id.length)
+
+    if (
+      results.table_id.length &&
+      typeof results.table_id[0].valueOf === "function"
+    ) {
+      // eslint-disable-next-line no-console
+      console.assert(
+        typeof results.table_id[0].valueOf === typeof results.row_id[0].valueOf
+      )
+      for (let i = 0; i < results.table_id.length; ++i) {
+        results.table_id[i] = results.table_id[i].valueOf()
+        results.row_id[i] = results.row_id[i].valueOf()
+      }
+    }
+
+    // For backwards compatibility, we need to make the returned results an array.
+    // Previously getResultRowForPixel results were passed thru the processPixelResults()
+    // function which converts the rsults into for a long time
+    // an array, so clients expect the results to be an array.
+    if (callback) {
+      return callback(error, [results])
+    } else {
+      return [results]
+    }
+  }
+
   // ** Configuration methods **
 
   /**
@@ -1934,6 +2012,60 @@ class MapdCon {
     })
   }
 
+  /**
+   * Clears cpu memory server-side.
+   * @param {Function} callback A callback that takes (`err, results`). When successful,
+   *                   err is null and results is undefined as the method returns nothing.
+   * @returns {undefined} This method returns nothing and instead relies on the callback
+   */
+  clearCpuMemory(callback) {
+    this._client[0].clear_cpu_memory(this._sessionId[0], callback)
+  }
+
+  /**
+   * Clears cpu memory server side.
+   * @returns {Promise.<undefined>} Undefined (when successful) or Error.
+   */
+  clearCpuMemoryAsync = this.handleErrors(
+    () =>
+      new Promise((resolve, reject) => {
+        this.clearCpuMemory((err, result) => {
+          if (err) {
+            reject(err)
+          } else {
+            resolve(result)
+          }
+        })
+      })
+  )
+
+  /**
+   * Clears gpu memory server-side.
+   * @param {Function} callback A callback that takes (`err, results`). When successful,
+   *                   err is null and results is undefined as the method returns nothing.
+   * @returns {undefined} This method returns nothing and instead relies on the callback
+   */
+  clearGpuMemory(callback) {
+    this._client[0].clear_gpu_memory(this._sessionId[0], callback)
+  }
+
+  /**
+   * Clears gpu memory server side.
+   * @returns {Promise.<undefined>} Undefined (when successful) or Error.
+   */
+  clearGpuMemoryAsync = this.handleErrors(
+    () =>
+      new Promise((resolve, reject) => {
+        this.clearGpuMemory((err, result) => {
+          if (err) {
+            reject(err)
+          } else {
+            resolve(result)
+          }
+        })
+      })
+  )
+
   isTimeoutError(result) {
     return (
       result instanceof TOmniSciException &&