allow downloading/uploading readable content #3960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sywhb
commented
May 16, 2024
Comment on lines
-247
to
-263
| const writableStream = storage | ||
| .bucket(bucketName) | ||
| .file(fileName) | ||
| .createWriteStream() | ||
|
|
||
| // Convert the string content to a readable stream | ||
| const readableStream = new stream.Readable() | ||
| readableStream.push(content) | ||
| readableStream.push(null) // Signal the end of the stream | ||
|
|
||
| // Pipe the readable stream to the writable stream to upload the file content | ||
| await new Promise((resolve, reject) => { | ||
| readableStream | ||
| .pipe(writableStream) | ||
| .on('finish', resolve) | ||
| .on('error', reject) | ||
| }) |
There was a problem hiding this comment.
I think streaming is not needed here because we still load the whole content in the memory and push it to the readStream at once so it should be the same effect as uploading the whole content at once
sywhb
commented
May 16, 2024
| @@ -426,79 +326,63 @@ export interface ProcessYouTubeTranscriptJobData { | |||
| export const processYouTubeTranscript = async ( | |||
| jobData: ProcessYouTubeTranscriptJobData | |||
| ) => { | |||
| try { | |||
There was a problem hiding this comment.
Removed the try catch block otherwise the failed jobs would never be retried
|
I simplified the code a bit, hopefully 😄 |
jacksonh
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.