Fix Python wheels missing constrained planning components (#1159)

* Install numpy before building Boost in CI * Make binding generation exceptions less silent * Update versions of actions for Python wheel CI
ompl · May 3, 2024 · 7f30de1 · 7f30de1
1 parent 632a350
commit 7f30de1
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/before_build.sh b/.github/workflows/before_build.sh
@@ -20,7 +20,7 @@ install_boost() {
     # multiple on the host system.
     python_include_path=$(python3 -c "from sysconfig import get_paths as gp; print(gp()['include'])")
     echo "using python : ${python_version} : : ${python_include_path} ;" > "$HOME/user-config.jam"
-
+    pip3 install numpy
     ./bootstrap.sh
     sudo ./b2 "${b2_args[@]}" \
         --with-serialization \

diff --git a/.github/workflows/wheels.yaml b/.github/workflows/wheels.yaml
@@ -22,7 +22,7 @@ jobs:
           submodules: 'recursive'
 
       - name: Build wheels
-        uses: pypa/cibuildwheel@v2.16.1
+        uses: pypa/cibuildwheel@v2.17.0
         with:
           package-dir: py-bindings
         env:
@@ -33,7 +33,7 @@ jobs:
           CIBW_BUILD: cp3{10,11,12}-macosx_{x86_64,arm64} cp3{7,8,9,10,11,12}-manylinux_x86_64
           CIBW_BUILD_VERBOSITY: 1
 
-      - uses: actions/upload-artifact@v3
+      - uses: actions/upload-artifact@v4
         with:
           name: wheels
           path: wheelhouse

diff --git a/py-bindings/generate_bindings.py b/py-bindings/generate_bindings.py
@@ -245,8 +245,9 @@ def filter_declarations(self):
             try:
                 # create a python type for each of their corresponding state types
                 state = self.ompl_ns.class_('ScopedState< ompl::base::%sStateSpace >' % stype)
-            except:
+            except Exception as e:
                 # ignore errors because of missing Boost.Numpy
+                print(f"Ignoring error due to missing Boost.Numpy: {e}")
                 continue
             state.rename(stype+'State')
             state.operator('=', arg_types=['::ompl::base::State const &']).exclude()
@@ -355,6 +356,7 @@ def filter_declarations(self):
                         try:
                             cls.member_function(method, arg_types=[signature, None]).add_transformation(FT.input(0))
                         except Exception as e:
+                            print(f"Ignoring constraint signature rewrite exception: {e}")
                             pass
 
             cls = self.ompl_ns.class_('Constraint')
@@ -364,9 +366,11 @@ def filter_declarations(self):
                     try:
                         cls.member_function(method, arg_types=[signature]).add_transformation(FT.input(0))
                     except Exception as e:
+                        print(f"Ignoring constraint signature rewrite exception: {e}")
                         pass
 
         except Exception as e:
+            print(f"Ignoring generation exception: {e}")
             pass
 
         # Exclude PlannerData::getEdges function that returns a map of PlannerDataEdge* for now