IntegerNode/FloatNode ValidationError message: include value type

[Jasha10]

Closes #743

The ValidationError raised by IntegerNode and FloatNode now contains the type of the value that triggered the error.

[omry]

looks good, one nit.

[omry]

As an alternative to creating a type here, you can use:

DictConfig({"bar": FloatNode(123.456)})

[Jasha10]

Ok, I made the change in f1b441d.

[Jasha10]

Currently we have this error message for numpy floats:

>>> cfg.bar = np.float32(0.9)
Traceback (most recent call last):
...
omegaconf.errors.ValidationError: Value '0.9' of type 'float32' could not be converted to Float

I've been experimenting with a diff to _utils.format_and_raise that includes the module name in the error message:

>>> cfg.bar = np.float32(0.9)
Traceback (most recent call last):
...
omegaconf.errors.ValidationError: Value '0.9' of type 'numpy.float32' could not be converted to Float

The diff looks like this:

diff --git a/omegaconf/_utils.py b/omegaconf/_utils.py
index d3dafe9..72bcc07 100644
--- a/omegaconf/_utils.py
+++ b/omegaconf/_utils.py
@@ -768,13 +768,18 @@ def format_and_raise(
         ref_type = get_ref_type(node)
         ref_type_str = type_str(ref_type)

+    value_type = type(value)
+    if hasattr(value_type, "__module__") and value_type.__module__ != "builtins":
+        value_type_str = value_type.__module__ + "." + value_type.__name__
+    else:
+        value_type_str = value_type.__name__
     msg = string.Template(msg).safe_substitute(
         REF_TYPE=ref_type_str,
         OBJECT_TYPE=object_type_str,
         KEY=key,
         FULL_KEY=full_key,
         VALUE=value,
-        VALUE_TYPE=f"{type(value).__name__}",
+        VALUE_TYPE=value_type_str,
         KEY_TYPE=f"{type(key).__name__}",
     )

@omry, what do you think?

[omry]

Since 2.1.0 is already out, please add a news fragment. otherwise looks good.

[omry]

@omry, what do you think?

lgtm, extract it to a function in _utils.
_fully_qualified_type_name?

Alternatively, and probably better - is to add support for fully-qualified-name to _utils.type_str.
It can handle compound types and annotations as well.

Either way works.