Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IntegerNode/FloatNode ValidationError message: include value type #744

Merged
merged 7 commits into from
Jun 7, 2021
Merged

IntegerNode/FloatNode ValidationError message: include value type #744

merged 7 commits into from
Jun 7, 2021

Commits on Jun 7, 2021

  1. IntegerNode/FloatNode ValidationError message: include value type

    @Jasha10
    Jasha10 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    1d9d2bf View commit details
    Browse the repository at this point in the history

  2. simplify test

    @Jasha10
    Jasha10 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f2965fa View commit details
    Browse the repository at this point in the history

  3. assign to FloatNode instead of creating from (ill-typed) structured c… 

    …onfig instance
    @Jasha10
    Jasha10 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f1b441d View commit details
    Browse the repository at this point in the history

  4. add include_module_name keyword argument to _utils.type_str

    @Jasha10
    Jasha10 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    d6eced0 View commit details
    Browse the repository at this point in the history

  5. use include_module_name=True for format_and_raise VALUE_TYPE

    @Jasha10
    Jasha10 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    c92e143 View commit details
    Browse the repository at this point in the history

  6. add news fragment

    @Jasha10
    Jasha10 committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    3bbb20b View commit details
    Browse the repository at this point in the history

  7. Update news fragment 

    Co-authored-by: Omry Yadan <omry@fb.com>
    @Jasha10 @omry
    Jasha10 and omry committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    609deeb View commit details
    Browse the repository at this point in the history