Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update regular expression so tests will pass on pypy #764

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Update regular expression so tests will pass on pypy #764

merged 1 commit into from
Jun 30, 2021

Conversation

Jasha10
Copy link
Collaborator

@Jasha10 Jasha10 commented Jun 30, 2021

This PR should fix the pypy error message that is causing conda-forge/omegaconf-feedstock#19 build to fail.

@omry
Copy link
Owner

omry commented Jun 30, 2021

Thanks.
Can you try to also add one version of pypy (say pypy 3.8) to the circleci file the project is using?
Not sure how hard this would be.

@Jasha10
Copy link
Collaborator Author

Jasha10 commented Jun 30, 2021

Not sure how hard this would be.

I'll give it a try.

@Jasha10 Jasha10 merged commit 4f07faa into omry:master Jun 30, 2021
@Jasha10 Jasha10 deleted the pypy_errmsg_patch branch June 30, 2021 22:26
@omry
Copy link
Owner

omry commented Jun 30, 2021

Let's limit to Linux only.

@benjaminrwilson benjaminrwilson mentioned this pull request Jun 30, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omry omry omry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jasha10 @omry