get protocol right if there is reverse proxy #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use 'x-forwarded-proto' header to get right protocol if there is a reverse proxy
|
Thanks for the contribution. Trusting the header arbitrarily is generally not great though. Probably doesn't have a real vector to be problematic in our situation, but could still lead to; overall, validating requests when it shouldn't. Would rather throw it behind an option (similar to express' If you are using express, enabling said trust proxy setting will get you what you're looking for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use 'x-forwarded-proto' header to get right protocol if there is a reverse proxy