Ensure that signature validation works behind SSL and reverse proxy #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #28. If you still find it necessary, I'd like it to be configurable, default off. |
|
That fixes my problem. Thanks for the pointer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Apache as a reverse proxy for a Node.js app using SSL, signature validation fails because of a protocol mismatch. As Apache is proxying to Node.js, the protocol on the request object will be
httpinstead ofhttps, causing signature validation to fail as the original URL containshttps. Therefore, we check if thex-forwarded-protoheader is present on the request and use that if it is.'x-forwarded-protois the standard header for specifying the forwarded protocol (https://tools.ietf.org/html/rfc7239 -->5.4. Forwarded Proto)