Outcome service bug fix and other changes #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change to the constructor makes it a bit easier to instantiate OutcomeService directly. Before you would have to either * store parts of the original request to create a provider * construct a mock provider to pass to the outcome service
…certificate. agent is removed from options otherwise request will ignore ca (see https://nodejs.org/api/https.html#https_https_request_options_callback)
|
Looks brilliant! Espcially that Outcome can easily be used afterwards without creating a fake request. |
|
Thanks for the contribution. I'll have time to go over it tonight. I'll look for myself, but is this breaking at all, or would it fit within a minor version? |
|
The change in signature to the |
|
Many apologies for not getting to this earlier - I'm sure it was quite annoying. |
|
No worries! Thanks for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit is a separate item. Three are related to outcome service. The last is to ensure that editors obey the 2 space indentation adopted in the project.
I'm using
ims-ltioutcome service to post grades to a server that uses a self-signed certificate. Thecaoption onhttps.requestmakes it possible to do this.Also, I'm posting the grades long after the launch request. Currently I'm storing parts of the original request, so that I can call
provider.parse_requestto in turn create the outcome service. I'd like to refactor the outcome service constructor to make it easier to create directly.Last, a small bug fix.
https.requestshould be used for ssl