Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outcome service bug fix and other changes #45

Closed
wants to merge 5 commits into from
Closed

Outcome service bug fix and other changes #45

wants to merge 5 commits into from

Commits on Apr 17, 2015

  1. Adding http://editorconfig.org/ file

    @ktonon
    ktonon committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    56683e7 View commit details
    Browse the repository at this point in the history

  2. For ssl, https should be used to make the request

    @ktonon
    ktonon committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    8f58cb4 View commit details
    Browse the repository at this point in the history

  3. The outcome service can be called long after the LTI launch request. 

    This change to the constructor makes it a bit easier to instantiate OutcomeService directly.

Before you would have to either

* store parts of the original request to create a provider
* construct a mock provider to pass to the outcome service
    @ktonon
    ktonon committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    0006b3f View commit details
    Browse the repository at this point in the history

  4. Make it possible to connect to an outcome service with a self-signed … 

    …certificate.

agent is removed from options otherwise request will ignore ca (see https://nodejs.org/api/https.html#https_https_request_options_callback)
    @ktonon
    ktonon committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    2c4f10c View commit details
    Browse the repository at this point in the history

  5. Forgot to require HMAC_SHA1 in outcomes module

    @ktonon
    ktonon committed Apr 17, 2015
    Configuration menu
    Copy the full SHA
    6ff46c2 View commit details
    Browse the repository at this point in the history