Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic data assimilation module #87

Open
wants to merge 13 commits into
base: mosaic
Choose a base branch
from

Conversation

JaroCamphuijsen
Copy link

@JaroCamphuijsen JaroCamphuijsen commented Oct 30, 2023

Resolves #82

Adds a new module, similar to the ERA5 module that can take any local data file (only supports netcdf format for now) and expose it as a model interface to the user. This enables easy data assimilation and forcing of the models.

  • Implementation
  • Settle on the naming
  • Add requirements to setup
  • Add tests
  • Add documentation

@JaroCamphuijsen
Copy link
Author

JaroCamphuijsen commented Oct 30, 2023

There is a problem of terminology here: for the MOSAIC project, it would be most logical to call this interface "Forcing", but in other domains that not used a lot. Also, the use of having a dataset being exposed as if it were a model can be used for other things than input forcing. For now I settled with calling the interface "Data" but I suppose that word is a bit overloaded already and might lead to problems in practical use. @goord @esclapez any ideas?

@goord
Copy link
Contributor

goord commented Oct 30, 2023

Hi Jaro, 'forcing' is indeed not a good name for this 'modelwrapper', forcing is usually reserved for external source terms in the PDE's of some other model. So I would expect 'forcing' to be a very generic part of the omuse model interface, such as its 'grid' or 'time evolution'.

So how about "ModelWrapper'?

@JaroCamphuijsen
Copy link
Author

ModelWrapper to me sounds too generic as almost every interface in OMUSE is a modelwrapper (they wrap around models). The unique thing about this interface is that it is about data. So "DataWrapper" would maybe be better. But it still doesn't really touch upon what it should do. Any other suggestions? Perhaps "ExternalData"?

@esclapez
Copy link
Contributor

esclapez commented Nov 1, 2023

I think "ExternalData" or "ImportedData" is a name I would relate to what this does if I came across it.

@JaroCamphuijsen JaroCamphuijsen marked this pull request as ready for review November 22, 2023 10:20
@JaroCamphuijsen JaroCamphuijsen changed the title Start on data assimilation module Basic data assimilation module Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants