-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add archive home #6
Conversation
src/app/page.tsx
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you add something specific or is it just prettier doing it's first formatting?
I noticed that strangely, it changed the top import to double quotes, which is not prettiers config. Also, the main element has an added space. So, I don't think prettier is configured properly for your env.
There's also an issue where the external link is missing it's _blank target (not your fault).
I ran a prettier format and pushed it to see if it would resolve this, but, it didn't, it appears your formatting is different. Maybe you have multiple formatting plugins working together. Or, prettier is not set as the default formatter in VS code.
I don't think there are any changes, so, I will just resolve the conflict by leaving it as is in origin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I figured this was Prettier doing it's thing so I included it for consistency, I'll look into my setup though since something must be different
{/* Global Header */} | ||
<WelcomeHeader | ||
heading={'Archived tools, files and other additional content'} | ||
description={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you need the empty tag <></>
This could just be wrapped in single quotes and concat to fit nicely. But, I suppose, it doesn't reallly matter. Just a little less efficient as a more complex object.
No description provided.