Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use proper interfaces #38

Closed
wants to merge 6 commits into from

Conversation

gosuto-inzasheru
Copy link
Member

i know this is a stupid optimisation but i wanted to get it right...

but it doesnt look like gnosispay/account-kit#38 actually solves our problem

@gosuto-inzasheru
Copy link
Member Author

Compiler run failed:
Error (9553): Invalid type for argument in function call. Invalid implicit conversion from enum Enum.Operation to IDelayModifier.Operation requested.
   --> src/RoboSaverVirtualModule.sol:299:92:
    |
299 |         delayModule.execTransactionFromModule(address(BALANCER_VAULT), 0, exitPoolPayload, Enum.Operation.Call);
    |                                                                                            ^^^^^^^^^^^^^^^^^^^

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from enum Enum.Operation to IDelayModifier.Operation requested.
   --> src/RoboSaverVirtualModule.sol:326:92:
    |
326 |         delayModule.execTransactionFromModule(address(BALANCER_VAULT), 0, exitPoolPayload, Enum.Operation.Call);
    |                                                                                            ^^^^^^^^^^^^^^^^^^^

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from enum Enum.Operation to IDelayModifier.Operation requested.
   --> src/RoboSaverVirtualModule.sol:367:80:
    |
367 |         delayModule.execTransactionFromModule(MULTICALL3, 0, multicallPayload, Enum.Operation.DelegateCall);
    |                                                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^

Error (9553): Invalid type for argument in function call. Invalid implicit conversion from enum Enum.Operation to IDelayModifier.Operation requested.
   --> src/RoboSaverVirtualModule.sol:383:73:
    |
383 |         delayModule.executeNextTx(cachedTarget, 0, txQueueData.payload, operation);
    |                                                                         ^^^^^^^^^

Error: 
Compilation failed

@gosuto-inzasheru
Copy link
Member Author

i opened foundry-rs/foundry#8379

@gosuto-inzasheru
Copy link
Member Author

not possible to programmatically create interfaces that preserve enums

@gosuto-inzasheru gosuto-inzasheru deleted the feat/use_proper_interfaces branch July 8, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant