Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make batches smaller and timeouts longer in Core #145

Merged
merged 1 commit into from Dec 9, 2021
Merged

make batches smaller and timeouts longer in Core #145

merged 1 commit into from Dec 9, 2021

Conversation

sheridancbio
Copy link
Contributor

We observed broken connections sporadically during annotation of mskimpact MAF files.

This eases the load by reducing batch size (from 1000 to 256), and increasing timeout limits (from 120s to 256s)

@sheridancbio sheridancbio mentioned this pull request Dec 3, 2021
Closed
zhx828
zhx828 approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@zhx828 zhx828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the number 265, but I don't see why I should reject this pr.

@zhx828
Copy link
Member

zhx828 commented Dec 9, 2021

I will merge once all tests pass.

@zhx828 zhx828 merged commit ed94ac2 into oncokb:master Dec 9, 2021
@sheridancbio sheridancbio deleted the ease-network-timeout branch December 13, 2021 16:33
@zhx828 zhx828 added the fix Fix tag for release label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhx828 zhx828 zhx828 approved these changes

Assignees
No one assigned
Labels
fix Fix tag for release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sheridancbio @zhx828