Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix latency of INT8 is slow issue #389

Merged
merged 63 commits into from Jan 6, 2021
Merged

Fix latency of INT8 is slow issue #389

merged 63 commits into from Jan 6, 2021

Conversation

arthw
Copy link
Contributor

@arthw arthw commented Dec 3, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Fix latency of INT8 is slow issue

Type of change

Please delete options that are not relevant. Add a 'X' to the one that is applicable.

  • [X Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Sample Migration (Moving sample from old repository after completing checklist established)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Command Line
  • oneapi-cli
  • Visual Studio
  • Eclipse IDE
  • VSCode

Checklist for Moving samples:

Links and Details can be found in the samples WG Teams Files.

NeoZhangJianyu and others added 30 commits September 28, 2020 12:56
* Add bitonic-sort sample.

* Add a note about common file in README.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Move 1d_HeatTransfer sample to open source GitHub.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Updating License file to remove date

* Adding Buffer Object approach.

* Add comment about the location of dpc_common.hpp.

* New sample: Prefix Sum.

* Remove new sample.

* New code sample PrefixSum in ParallelPatterns.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Integrate MPI code sample with dpc_reduce code sample.

* Update README.md

* Update main.cpp

* Integrate MPI with latest dpc_reduce for beta09.

* Update README.md

* Update main.cpp

* Update main.cpp

* Update README.md

* Update CXX to icpx and compiler option for beta09.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Add "export I_MPI_CXX=dpcpp" in sample.json file.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Update json file.

* Sync with master.

* Update bitonic-sort code sample according to the latest guideline.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
* Add bitonic-sort sample.

* Add a note about common file in README.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Move 1d_HeatTransfer sample to open source GitHub.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Updating License file to remove date

* Adding Buffer Object approach.

* Add comment about the location of dpc_common.hpp.

* New sample: Prefix Sum.

* Remove new sample.

* New code sample PrefixSum in ParallelPatterns.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Integrate MPI code sample with dpc_reduce code sample.

* Update README.md

* Update main.cpp

* Integrate MPI with latest dpc_reduce for beta09.

* Update README.md

* Update main.cpp

* Update main.cpp

* Update README.md

* Update CXX to icpx and compiler option for beta09.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Add "export I_MPI_CXX=dpcpp" in sample.json file.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Update json file.

* Sync with master.

* Update the PrefixSum code sample according to the latest guidelines.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Update based on comments from reviewer.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Restructure the Usage function.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
* Add bitonic-sort sample.

* Add a note about common file in README.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Move 1d_HeatTransfer sample to open source GitHub.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Updating License file to remove date

* Adding Buffer Object approach.

* Add comment about the location of dpc_common.hpp.

* New sample: Prefix Sum.

* Remove new sample.

* New code sample PrefixSum in ParallelPatterns.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Integrate MPI code sample with dpc_reduce code sample.

* Update README.md

* Update main.cpp

* Integrate MPI with latest dpc_reduce for beta09.

* Update README.md

* Update main.cpp

* Update main.cpp

* Update README.md

* Update CXX to icpx and compiler option for beta09.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Add "export I_MPI_CXX=dpcpp" in sample.json file.

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

* Update json file.

* Sync with master.

* Update 1d_HeatTransfer code sample according to the new guideline.

* Add comment about dpc_common.hpp .

Signed-off-by: Loc Nguyen <loc.q.nguyen@intel.com>

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
* Adding mandelbrot sample to the repository

Signed-off-by: vmadanan <varsha.madananth@intel.com>

* Adding changes to mandelbrot to remove libsycl-complex.so dependency

* namespace change for Monte Carlo

* Updated samples to newest coding guidelines

* Updating samples- Mandelbrot, DCT and MonteCarlo with newest coding guidelines
* Initial commit for iso3dfd_dpcpp code sample

Signed-off-by: Gogar, Sunny L <sunny.l.gogar@intel.com>

* Update License.txt

* Update sample.json

* Adding iso3dfd_omp_offload and changing dpc++ compile for windows to dpcpp

* Delete .nfs000000043228fc3f00000140

* Removing build directory accidently checked in

* Update sample.json

Fixing a missing comma

* Adding couple of changes as per Paul's recommendation

* Updating some variable names as per guidelines

* Moving iso3dfd_omp_offload to C++ folder

* Fixing a windows related error about missing std:: for tranform

* Adding algorithm header explicity in iso3dfd.h

* Fixing the sample.json to eliminate recent errors

* Adding changes to buffer and accessor declarations
* Update simple add sample

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Update make files

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Update fpga make file

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Add dpc_common.hpp

* Update sample.json

* Fix Makefile.win

* Update Makefile.win

* Update sample.json

* Remove dpc_common.hpp

* Update VS project file

* Update README.md

* Update sample.json

* Add stb

* Update read me file

* Initial commit

* Update License.txt

* Change location of matrix multiplication sample

* Fix matrix mul sample VS project file

* Update samples for beta10 release

* Fix for Windows

* Fix for FPGA

* Fix for FPGA

* Fix for FPGA to support both beta09 and beta10

* Add header comment

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
* Beta10 GZIP update -- use USM for data transfer

Signed-off-by: Audrey Kertesz <audrey.kertesz@intel.com>

* Trivial change to re-trigger CI

Signed-off-by: Audrey Kertesz <audrey.kertesz@intel.com>
* Update top-level README and improve format

Signed-off-by: Audrey Kertesz <audrey.kertesz@intel.com>

* Minor formatting update

Signed-off-by: Audrey Kertesz <audrey.kertesz@intel.com>
* initial commit of openMP example.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* Initial commit of the dpc_reduce

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* added guid to sample.json

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* fixed sample.json files.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* fixed the include files.  Somehow I copied a slightly old repo and it still had <chrono> and the omp_common.hpp file.  They have been removed.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* added license.txt file ran through formating tool one more time removed all calls to "std::endl" and replaced with " \n"

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* renamed license.txt to License.txt

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* added "ciTests" to the sample.json file.  It passed the check.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* fixed make error

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* fixed sample.json

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* removed "2020" from the License.txt file due to update guidelines.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* added comment regarding where you can find dpc_common in both files per Paul's comments.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* Modified names of the functions to represent what they do (ie. calc_pi_*) per suggestion from Paul.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* initial check-in to the C++ repo

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* put correct comment on dpc_common.hpp

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* added commenting indicating where they can find corresponding include files.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* added comment line

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* removed openMP repo from DPC++ as it will be moved to C++ directory

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* fixed category line in sample.json to match exact text expected.

* removing openMP from the DPC directory.  It has been moved to C++ directory.

* fixed tf_init call

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* removed all calls into PSTL internal logic.  This is what was causing fails between beta08 and beta09.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* fixed env variable to run on CPU

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* update Readme file to include information about setting
env variable to allocate more memory for any runs
on the cpu

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* added option in Cmake file to support unnamed lambda option.   You need this to compile if the environment doesn't have this set by default.

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* path to output file from compile has changed.  it no longer seems to create the src directory.

* started to remove get_access and change it to accessor name()

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* fixed remaining get_access

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* removed commented out old code

Signed-off-by: todd.erdner <todd.erdner@intel.com>

* Fixed path in Cmakelists.txt to suport both beta10 and beta09.  The location of the oneDPL
library changed between the two releases.

* Update CMakeLists.txt

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
* Added new Sample (TensorFlow Multinode Training with Horovod)

Signed-off-by: Shailen Sobhee <shailen.sobhee@intel.com>

* Fixed assert reported by bandit code checker tool.

Signed-off-by: Shailen Sobhee <shailen.sobhee@gmail.com>

* Fix CI issue (MPI bug) - Upload to new folder structure

Signed-off-by: Shailen Sobhee <shailen.sobhee@gmail.com>

* Minor little fix in sample.json; A comma was missing.

Signed-off-by: Shailen Sobhee <shailen.sobhee@gmail.com>

* Removed old references to old folder structure

Signed-off-by: Shailen Sobhee <shailen.sobhee@gmail.com>
* Updating License  file to no date in the title /*
 * Copyright (c) 2020 Intel Corporation
 *
 * This program and the accompanying materials are made available under the
 * terms of the The MIT License which is available at
 * https://opensource.org/licenses/MIT.
 *
 * SPDX-License-Identifier: MIT
 */

* Update README.md

* Fix FPGA entries

* Update README.md

Updates per request of sranikonda

* Update README.md

* removing duplicate samples after transfering to dwarves folders

* Update Makefile.win

changing compiler name from "dpcpp-cl" to "dpcpp"

* Update Makefile.win

* Update Makefile.win.fpga

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update README.md

* Update README.md

* Update from Legal Approval of 10/05/2020

Co-authored-by: akertesz <67655634+akertesz@users.noreply.github.com>
…x_multiply Advisor and VTune). (#215)

* TBB Samples Migration

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* Addressing PR Change Requests

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* Fill in "Purpose" Section of both README files.

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* Remove binary and build files

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* include dpc_common header, remove exception handler, fix json files. (all changes apply to both samples)

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* include dpc_common headers, remove exception handlers (both samples)

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* Fix README files, include header files for windows

* Remove namespace, end files, use "std::iota", fix README

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* fix README

Signed-off-by: root <root@dtc-nuc-03l.jf.intel.com>

* Fix "matrix_multiply" samples failures on Windows.

* buffer/accessor updates for coding guidelines (matrix mul).

Co-authored-by: root <root@dtc-nuc-03l.jf.intel.com>
* updated the simplied version of the accessors, used auto for parallel_for
index

* using vector.size() instead of the global variables as per the comments

* fixed the typo. Also check the output vector size

* Updated Readme to add the include files path for dpc_common.hpp
Updated the cpp file with the comments on dev_utilities folder

* Updated the Jupyter notebooks as per the beta10 guidelines <praveen.k.kundurthy@intel.com>

* removed sample.json as these are jupyter notebooks <praveen.k.kundurthy@intel.com>

* removed some checkpoint files that are not necessary <praveen.k.kundurthy@intel.com>

* removed unwanted files <praveen.k.kundurthy@intel.com>

* removed unwanted checkpoint files <praveen.k.kundurthy@intel.com>
* Update simple add sample

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Update make files

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Update fpga make file

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Add dpc_common.hpp

* Update sample.json

* Fix Makefile.win

* Update Makefile.win

* Update sample.json

* Remove dpc_common.hpp

* Update VS project file

* Update README.md

* Update sample.json

* Add stb

* Update read me file

* Initial commit

* Update License.txt

* Change location of matrix multiplication sample

* Fix matrix mul sample VS project file

* Update samples for beta10 release

* Fix for Windows

* Fix for FPGA

* Fix for FPGA

* Fix for FPGA to support both beta09 and beta10

* Add header comment

* Samples: block apsp and merge spmv

* Add readme files

* Update readme file

* Update sample.json

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
* Update simple add sample

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Update make files

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Update fpga make file

Signed-off-by: Maria, Moushumi <moushumi.maria@intel.com>

* Add dpc_common.hpp

* Update sample.json

* Fix Makefile.win

* Update Makefile.win

* Update sample.json

* Remove dpc_common.hpp

* Update VS project file

* Update README.md

* Update sample.json

* Add stb

* Update read me file

* Initial commit

* Update License.txt

* Change location of matrix multiplication sample

* Fix matrix mul sample VS project file

* Update samples for beta10 release

* Fix for Windows

* Fix for FPGA

* Fix for FPGA

* Fix for FPGA to support both beta09 and beta10

* Add header comment

* Samples: block apsp and merge spmv

* Add readme files

* Update readme file

* Update sample.json

* Update sample.json

Co-authored-by: JoeOster <52936608+JoeOster@users.noreply.github.com>
* Updating License  file to no date in the title /*
 * Copyright (c) 2020 Intel Corporation
 *
 * This program and the accompanying materials are made available under the
 * terms of the The MIT License which is available at
 * https://opensource.org/licenses/MIT.
 *
 * SPDX-License-Identifier: MIT
 */

* Update README.md

* Fix FPGA entries

* Update README.md

Updates per request of sranikonda

* Update README.md

* removing duplicate samples after transfering to dwarves folders

* Update Makefile.win

changing compiler name from "dpcpp-cl" to "dpcpp"

* Update Makefile.win

* Update Makefile.win.fpga

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update CMakeLists.txt

* Update README.md

* Update README.md

* Update from Legal Approval of 10/05/2020

* Create README.md

* Add files via upload

* Update README.md

minor modifications to content, purpose and key implementation details.

* Update sample.json

aligned description with readme

* Update README.md

reshuffled parts of the purpose and implementation details and abstracted a few key concepts into better summaries.

* Update sample.json

synched description with readme.

* Update README.md

Co-authored-by: akertesz <67655634+akertesz@users.noreply.github.com>
Co-authored-by: tomlenth <tom.f.lenth@intel.com>
JoeOster
JoeOster previously approved these changes Dec 3, 2020
Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for ci

JoeOster
JoeOster previously approved these changes Dec 3, 2020
Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for ci

Copy link
Contributor

@JoeOster JoeOster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving for ci

@JoeOster JoeOster merged commit 4362b3e into oneapi-src:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet