maint: changes for 2025.0 compiler #2868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexandr-Solovev
requested review from
Alexsandruss and
samir-nasibli
as code owners
|
/intelci: run |
1 similar comment
|
/intelci: run |
icfaust
approved these changes
Aug 9, 2024
samir-nasibli
approved these changes
Aug 9, 2024
|
Looking good - can we ensure than CI job with nightly (not CEV) is running smoothly? |
|
Hi @ethanglaser , nope, with this pr CEV/MEV will be red, but due to it necessary intel/scikit-learn-intelex#2000, I guess we can merge it in the same time as we merge your prs with cl removals |
Yes I mean regular nightly scope (not CEV) |
Alexandr-Solovev
changed the title
|
/intelci: run |
|
/intelci: run |
Alexandr-Solovev
changed the title
|
/intelci: run |
|
/intelci: run |
1 similar comment
|
/intelci: run |
|
/intelci: run |
homksei
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Maint: Changes for 2025.0 Compiler Compatibility
Summary:
This PR updates the oneDAL codebase for compatibility with the upcoming 2025.0 compiler version. It includes fixes and modifications across multiple files to address issues related to the new compiler requirements.
Key Changes:
Compute Kernel CSR Implementation:
compute_kernel_csr_impl_dpc.cppfor conditional compilation ofsycl::fminandsycl::fmax.Compute Kernel Dense Implementation:
compute_kernel_dense_impl_dpc.cppfor proper handling ofsycl::sqrt.Test Adjustments:
badargs.cpp,overflow.cpp) for algorithms likecovariance,dbscan,kmeans,linear_kernel, andpca.Backend and Primitives: