Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Fix online SPMD algorithms finalize call #2882

Merged
merged 2 commits into from
Aug 29, 2024
Merged

[fix] Fix online SPMD algorithms finalize call #2882

merged 2 commits into from
Aug 29, 2024

Conversation

olegkkruglov
Copy link
Contributor

Changes proposed in this pull request:

  • Fix finalize method for all four online SPMD algorithms, now the call does not affect partial results since all necessary tables are copied. It allows to call finalize between calls of partial_fit to obtain intermediate results
  • Add ONEDAL_DATA_PARALLEL to finalize implementations where they were forgotten

@olegkkruglov olegkkruglov requested review from Alexandr-Solovev and removed request for Alexandr-Solovev August 28, 2024 13:47
@olegkkruglov
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor

/intelci: run

@olegkkruglov
Copy link
Contributor Author

http://intel-ci.intel.com/ef65eab3-b487-f188-a43a-a4bf010d0e2e

@olegkkruglov olegkkruglov merged commit ac5ea85 into oneapi-src:main Aug 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexandr-Solovev Alexandr-Solovev Alexandr-Solovev approved these changes

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

@samir-nasibli samir-nasibli Awaiting requested review from samir-nasibli samir-nasibli is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olegkkruglov @Alexandr-Solovev