Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix __pattern_partial_sort_copy forward declaration #1598

Merged

Conversation

SergeyKopienko
Copy link
Contributor

@SergeyKopienko SergeyKopienko commented May 22, 2024

Fix __pattern_partial_sort_copy forward declaration :

  • we forgot to declare __pattern_partial_sort_copy with __parallel_tag as the first param.

Instead we had two declarations of the same __pattern_partial_sort_copy :

template <class _Tag, class _ExecutionPolicy, class _ForwardIterator, class _RandomAccessIterator, class _Compare>
_RandomAccessIterator
__pattern_partial_sort_copy(_Tag, _ExecutionPolicy&&, _ForwardIterator, _ForwardIterator, _RandomAccessIterator,
                            _RandomAccessIterator, _Compare) noexcept;

This issue has been introduced in the PR #1239

…copy forward declaration

Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
…copy forward declaration

Signed-off-by: Sergey Kopienko <sergey.kopienko@intel.com>
Copy link
Contributor

@MikeDvorskiy MikeDvorskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dmitriy-sobolev dmitriy-sobolev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergeyKopienko SergeyKopienko merged commit c6e5871 into main May 22, 2024
20 checks passed
@SergeyKopienko SergeyKopienko deleted the dev/skopienko/pattern_partial_sort_copy_fwd_decl_fix branch May 22, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants