New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing onetbb build for MacOS X PPC: almost ready for PR, can someone take a look? #819
Comments
oneTBB is neither officially nor community supported on mac32 any longer. If you want to restore that file, test it on your own system and submit a PR, you can do that. But we do not intend to provide ongoing support. |
@vossmjp Thank you. I will try to do that. |
@vossmjp UPD. I dug into the code, and fixing PPC appears far less easy than just restoring two mac32 def files. For one thing, new version of |
Ok, no problem. The mac32 support was dropped during a major refactoring that went on between TBB and oneTBB. So yes, lets keep the issue open while you investigate further. |
@vossmjp Besides, do you know how |
@barracuda156 TBB was first released before even C++11. The refactoring done when moving to oneTBB including using some modern C++ features, such as std::atomic. Much of the machine-specific code in early versions of TBB was assembly code for atomic operations. As the project moved to modern C++ features, some of the machine-specific code was simply replaced by more portable, but still performant, C++ code. This reduced the number of machine-specific files and lines of code. |
@vossmjp Thank you! So those won't have to be restored even for PPC arch, given that we got C++11-supporting compilers on it (gcc10, gcc11), right? |
@vossmjp Sorry for a delay, been busy with other stuff. I have built Aside of that, few minor patches had to be added. Lists of symbols are effectively identical, from what I can see, so my initial concern was unfounded. I had to delete two for Mac32 though:
Dunno how crucial is that. (It is a bit surprising that original defs contain few duplicate symbols.) |
@vossmjp Here is my PR in Macports: macports/macports-ports#14760 If you or someone could comment on these two issues, it will be greatly appreciated. The rest should be uncontroversial, and then I can open a PR here.
|
Yes we will take a look at it. |
@vossmjp Many thanks! By the way, does it actually need 2017 C standard or 2011 suffices? Macports has 2011 in the portfile and it does indeed build with |
UPD. While it builds on 10.6 PPC (10A190) and 10.6.8 Rosetta, the build fails on 10.5.8 with:
I will look into that. |
UPD2. Well, with this change to one of the patches
|
@vossmjp An updated PR on Macports: macports/macports-ports#14780 (I closed the original one due to messing up git rebase) |
@vossmjp Just in case, I understand you and others may not have hardware and/or time to do actual testing for PPC, so I only expect either “good to go” verdict (and then I can make PR here to |
mac32-tbbmalloc-export.def
has been removed at some point, apparently, and due to that building on PowerPC fails. Earlier version oftbb
had that file. Is it possible to restore it?The text was updated successfully, but these errors were encountered: