Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiler warning for missing virtual dtor #1215

Merged
merged 1 commit into from Sep 27, 2023
Merged

Fix compiler warning for missing virtual dtor #1215

merged 1 commit into from Sep 27, 2023

Conversation

elias-plank
Copy link
Contributor

@elias-plank elias-plank commented Sep 25, 2023 •
edited by dnmokhov

Description

This fixes issue #1210 by declaring a default virtual destructor for tbb::detail::r1::control_storage.

Fixes #1210

  • - git commit message contains an appropriate signed-off-by string

Type of change

  • bug fix
  • new feature
  • tests
  • infrastructure
  • documentation

Tests

  • added
  • not needed

Documentation

  • needs to be updated
  • not needed

Breaks backward compatibility

  • Yes
  • No
  • Unknown

isaevil
isaevil reviewed Sep 26, 2023
View reviewed changes
src/tbb/global_control.cpp Outdated Show resolved Hide resolved
isaevil
isaevil approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@isaevil isaevil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elias-plank
Fix compiler warning for missing virtual dtor
33049a0 
This fixes issue #1210 by adding a default virtual destructor for tbb::detail::r1::control_storage.

Signed-off-by: Elias Engelbert Plank <plank.elias.engelbert@gmail.com>
@elias-plank
Copy link
Contributor Author

Thanks, I squashed my commits, should be fine to merge 😁

@elias-plank
Copy link
Contributor Author

elias-plank commented Sep 27, 2023 •
edited

Somehow the documentation CI is failing, the logs state that the operation was cancelled 🤔 Maybe rerunning the CI check helps? If the checks work again, feel free to merge.

@isaevil
Copy link
Contributor

isaevil commented Sep 27, 2023

Somehow the documentation CI is failing, the logs state that the operation was cancelled 🤔 Maybe rerunning the CI check helps? If the checks work again, feel free to merge.

This check is unrelated to changes of this PR.

@isaevil isaevil merged commit 7eb68ae into oneapi-src:master Sep 27, 2023
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isaevil isaevil isaevil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C4265: tbb::detail::r1::control_storage has no virtual destructor
2 participants
@elias-plank @isaevil