Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: single file commands and queries #58

Merged
merged 14 commits into from
Dec 13, 2023
Merged

FEAT: single file commands and queries #58

merged 14 commits into from
Dec 13, 2023

Conversation

matthewtoghill
Copy link
Collaborator

@matthewtoghill matthewtoghill commented Dec 8, 2023 •
edited by CesarD
Loading

Description

Refactor the command and query classes such that each Command or Query is a single class with subclasses that implement the required Handler as well as any related Validator for Commands.

Unit tests have also been updated to reference the new Command and Query structure.

Related Issue

Implements and closes #57

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CesarD CesarD self-requested a review December 9, 2023 06:57
CesarD
CesarD requested changes Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@CesarD CesarD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job!
Although, the tests need to change their structure too, as they represent the old one. We need to mimic the same structure than the stuff we are testing to provide the same navigation experience.

CesarD
CesarD requested changes Dec 13, 2023
View reviewed changes
...ntent/Backend/Solution/Monaco.Template.Backend.Application/DTOs/Extensions/FileExtensions.cs Outdated Show resolved Hide resolved
src/Content/Backend/Solution/Monaco.Template.Backend.Application/DTOs/FileDownloadDto.cs Outdated Show resolved Hide resolved
src/Content/Backend/Solution/Monaco.Template.Backend.Application/DTOs/FileDto.cs Outdated Show resolved Hide resolved
src/Content/Backend/Solution/Monaco.Template.Backend.Application/DTOs/ImageDto.cs Outdated Show resolved Hide resolved
...tion/Monaco.Template.Backend.Application.Tests/Features/Company/CreateCompanyHandlerTests.cs Outdated Show resolved Hide resolved
...on/Monaco.Template.Backend.Application.Tests/Features/Company/CreateCompanyValidatorTests.cs Outdated Show resolved Hide resolved
...tion/Monaco.Template.Backend.Application.Tests/Features/Company/DeleteCompanyHandlerTests.cs Outdated Show resolved Hide resolved
...on/Monaco.Template.Backend.Application.Tests/Features/Company/DeleteCompanyValidatorTests.cs Outdated Show resolved Hide resolved
...lution/Monaco.Template.Backend.Application.Tests/Features/Company/EditCompanyHandlerTests.cs Outdated Show resolved Hide resolved
...tion/Monaco.Template.Backend.Application.Tests/Features/Company/EditCompanyValidatorTests.cs Outdated Show resolved Hide resolved
@CesarD CesarD merged commit 32a6128 into onebeyond:main Dec 13, 2023
@matthewtoghill matthewtoghill deleted the feat/single-file-commands-queries branch December 13, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CesarD CesarD CesarD approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FEATURE: Single file commands/queries
2 participants
@matthewtoghill @CesarD