Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up commitlinter #20

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Conversation

tiago154
Copy link
Contributor

@tiago154 tiago154 commented Oct 1, 2021

What’s the focus of this PR

Add 2 packages (husky and commitlint), to perform best practices validation before performing a commit.

How to review this PR

  • Check file changes
  • Install dependencies with npm install command
  • Create any file and commit without the best practices.

Related work items

Before submitting this PR, I made sure:

  • The code builds clean without any errors or warnings
  • I've added tests

Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tiago154 !

Thanks for your contribution. Could you solve the conflicts of this PR before reviewing it? Thanks!

@tiago154
Copy link
Contributor Author

tiago154 commented Oct 6, 2021

Hi @tiago154 !

Thanks for your contribution. Could you solve the conflicts of this PR before reviewing it? Thanks!

@inigomarquinez

Of course, I fixed the conflicts and now it's alright.

Copy link
Member

@inigomarquinez inigomarquinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Fantastic! Thanks for your contrinution @tiago154 !

@inigomarquinez inigomarquinez merged commit 58bc307 into onebeyond:main Oct 6, 2021
@inigomarquinez inigomarquinez mentioned this pull request Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants