Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve control-C support during uploads #42

Closed
boydgreenfield opened this issue Jan 21, 2017 · 1 comment
Closed

Improve control-C support during uploads #42

boydgreenfield opened this issue Jan 21, 2017 · 1 comment
Assignees
@polyatail
Labels
enhancement
Milestone
Sprint Kiwi

Comments

@boydgreenfield
Copy link
Contributor

For samples over 5GB, this causes the CLI progress bar to take off before the Aborted! eventually gets printed. We should more gracefully handle control-C here and in the normal <5GB upload case.
@polyatail polyatail self-assigned this Jan 8, 2019
@polyatail polyatail added this to the Sprint Kiwi milestone Jan 8, 2019
@polyatail
Copy link
Contributor

The solution to this issue is more substantial than it seems. We should add a route to the API to cancel uploads in progress, so we don't leave partially uploaded files hanging. On Ctrl+C, this route should be requested before closing.

polyatail added a commit that referenced this issue Jan 19, 2019
@polyatail
Use cancel_upload() route on KeyboardInterrupt. Closes #42.
ede5ecf 
* Retry failed proxy uploads to intermediate S3 bucket
polyatail added a commit that referenced this issue Jan 19, 2019
@polyatail
Use cancel_upload() route on KeyboardInterrupt. Closes #42.
e5c738c 
* Retry failed proxy uploads to intermediate S3 bucket
polyatail added a commit that referenced this issue Jan 21, 2019
@polyatail
Use cancel_upload() route on KeyboardInterrupt. Closes #42.
5efaf6f 
* Retry failed proxy uploads to intermediate S3 bucket
polyatail added a commit that referenced this issue Jan 22, 2019
@polyatail
Use cancel_upload() route on KeyboardInterrupt. Closes #42.
67dea24 
* Retry failed proxy uploads to intermediate S3 bucket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polyatail polyatail

Labels
enhancement
Projects
None yet
Milestone
Sprint Kiwi
Development

No branches or pull requests
2 participants
@boydgreenfield @polyatail