Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first attempt at devcontainer #1025

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Conversation

moenzuel
Copy link
Contributor

Changed a lot from my setup but I think I got all the current recommended client deps. Could be a default devcontainer that supports the initial bootstrap or maybe it makes more sense as an addon?

@onedr0p
Copy link
Owner

onedr0p commented Nov 20, 2023

Another question, I think we need to find a way to pull in all the deps including the binaries?

https://github.com/onedr0p/flux-cluster-template/blob/main/.taskfiles/BrewTasks.yaml#L16-L25

@moenzuel
Copy link
Contributor Author

Another question, I think we need to find a way to pull in all the deps including the binaries?

https://github.com/onedr0p/flux-cluster-template/blob/main/.taskfiles/BrewTasks.yaml#L16-L25

Those should all be included already. Are there additional deps that brew includes that are missing? Or did you mean to read that brew tasks file?

@onedr0p
Copy link
Owner

onedr0p commented Nov 20, 2023

Another question, I think we need to find a way to pull in all the deps including the binaries?
https://github.com/onedr0p/flux-cluster-template/blob/main/.taskfiles/BrewTasks.yaml#L16-L25

Those should all be included already. Are there additional deps that brew includes that are missing? Or did you mean to read that brew tasks file?

If they're included that's fine then, I wasn't seeing where all those deps where being pulled in from in the config file.

@moenzuel
Copy link
Contributor Author

Another question, I think we need to find a way to pull in all the deps including the binaries?

https://github.com/onedr0p/flux-cluster-template/blob/main/.taskfiles/BrewTasks.yaml#L16-L25

Those should all be included already. Are there additional deps that brew includes that are missing? Or did you mean to read that brew tasks file?

If they're included that's fine then, I wasn't seeing where all those deps where being pulled in from in the config file.

The assorted included features handle that. It is non obvious though to someone who isn't familiar on where to look to find the information. I'll add some comments to hopefully help everyone.

@onedr0p
Copy link
Owner

onedr0p commented Nov 24, 2023

I haven't forgot about this, I'll pull these changes in and test it out soon.

@onedr0p
Copy link
Owner

onedr0p commented Nov 25, 2023

I wish there was a way renovate could work on those deps or to always have the latest versions installed, I can see myself forgetting to update them.

@mircea-pavel-anton
Copy link

mircea-pavel-anton commented Nov 25, 2023

@onedr0p @moenzuel

I've been playing around with setting up a devcontainer for my repo today, without being aware of this PR. I saw there is support for providing a custom Dockerfile for it, which is the route I decided to take since I already had one for my repo.

My question is, could we go for an approach similar to this https://github.com/mirceanton/home-ops/blob/main/Dockerfile and maybe swap the base image for the one specified in the devcontainer.json?

Renovate can handle updating the version tags in this Dockerfile as it has been doing that for my repo.

@onedr0p
Copy link
Owner

onedr0p commented Nov 25, 2023

@mirceanton I am not opposed to the idea, however the current method used here it a bit more lightweight, (probably) faster to start and can always pull the latest deps without having me or renovate manage it.

@moenzuel
Copy link
Contributor Author

@onedr0p @mirceanton I am not completely opposed to a custom docker container but I think devcontainer features are easier for new people to make changes. For instance I don't use cilium or cloudflared in my cluster and I am working towards dropping age/sops. With devcontainer features adding and discovering new ones is just looking at the Microsoft hosted list vs in a custom container you need to figure out the setup and configuration yourself. Additionally features should be oci artifacts which I think allows the container layer to be cached and thus speedup container rebuilds.

@onedr0p
Copy link
Owner

onedr0p commented Nov 27, 2023

I'll go ahead and merge this, I created an issue to document the use of this once I am more familiar with it in my own repo!
#1047

Thanks @moenzuel !

@onedr0p onedr0p merged commit 6613f15 into onedr0p:main Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants